gemini-code-assist[bot] commented on PR #37587: URL: https://github.com/apache/beam/pull/37587#issuecomment-3893884489
## Summary of Changes Hello @derrickaw, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on code cleanup and modernization by eradicating a deprecated file listing method across multiple cloud storage I/O connectors. The change ensures that all internal operations and tests now exclusively utilize the current and recommended file listing mechanism, thereby improving code hygiene and preventing future issues related to deprecated API usage. ### Highlights * **Removal of Deprecated Method**: The `list_prefix` method, which was previously marked as deprecated since version 2.45.0, has been completely removed from `s3io.py`, `blobstorageio.py`, and `gcsio.py`. * **Migration to `list_files`**: All internal and test usages of the removed `list_prefix` method have been updated to use the recommended `list_files` method across S3, Azure Blob Storage, and GCS I/O implementations. * **Deprecation Warning Elimination**: By removing the deprecated method and updating its call sites, this change eliminates deprecation warnings that would appear in test logs, contributing to cleaner and more maintainable code. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/python/apache_beam/io/aws/s3io.py** * Removed the import of the `deprecated` annotation. * Deleted the `list_prefix` method. * Updated calls to `list_prefix` in `copy_tree` and `delete_tree` to use `list_files` and correctly unpack its generator output. * Adjusted a logging message to refer to `list_files` instead of `list_prefix`. * **sdks/python/apache_beam/io/aws/s3io_test.py** * Modified `test_copy`, `test_copy_tree`, `test_rename`, and `test_delete` to use `dict(self.aws.list_files(...))` instead of `self.aws.list_prefix(...)` for compatibility. * Renamed `test_list_prefix` to `test_list_files` to reflect the updated method being tested. * Updated assertions in the renamed `test_list_files` to correctly compare the output of `list_files`. * **sdks/python/apache_beam/io/azure/blobstorageio.py** * Removed the import of the `deprecated` annotation. * Deleted the `list_prefix` method. * Updated calls to `list_prefix` in `copy_tree` and `delete_tree` to use `list_files` and correctly unpack its generator output. * Adjusted a logging message to refer to `list_files` instead of `list_prefix`. * **sdks/python/apache_beam/io/external/xlang_bigqueryio_it_test.py** * Updated the `assert_iceberg_tables_created` function to call `gcs_io.list_files` instead of `gcs_io.list_prefix`. * **sdks/python/apache_beam/io/gcp/gcsio.py** * Removed the import of the `deprecated` annotation. * Deleted the `list_prefix` method. * Updated calls to `list_prefix` in `copytree` to use `list_files` and correctly unpack its generator output. * Adjusted a logging message to refer to `list_files` instead of `list_prefix`. * **sdks/python/apache_beam/io/gcp/gcsio_test.py** * Renamed `test_list_prefix` to `test_list_files` to reflect the updated method being tested. * Updated assertions in the renamed `test_list_files` to correctly compare the output of `list_files`. * **sdks/python/apache_beam/runners/interactive/cache_manager.py** * Updated the `size` method to use `sum(s for _, s in gcsio.GcsIO().list_files(path))` instead of `sum(gcsio.GcsIO().list_prefix(path).values())`. </details> <details> <summary><b>Activity</b></summary> * No human activity (comments, reviews) has been recorded on this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
