gemini-code-assist[bot] commented on PR #37593: URL: https://github.com/apache/beam/pull/37593#issuecomment-3897668997
## Summary of Changes Hello @claudevdm, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the handling of `TaggedOutput` type annotations within Apache Beam's type hinting system. The primary goal is to introduce update compatibility, ensuring that existing pipelines using `TaggedOutput` annotations continue to function as expected when upgrading to newer Beam versions. This is achieved by conditionally applying new type extraction logic based on the pipeline's compatibility version, preventing breaking changes while allowing for more precise type inference in modern contexts. ### Highlights * **Update Compatibility for TaggedOutput Annotations**: Introduced logic to ensure that `TaggedOutput` type annotations behave consistently across different Apache Beam compatibility versions, specifically for versions prior to 2.72.0. * **Refined TaggedOutput Extraction**: Modified the `extract_tagged_outputs` method to correctly handle cases where `TaggedOutput` is used in a union type (e.g., `int | TaggedOutput`) without explicit tags, while also respecting existing explicit tag definitions. * **New Test Coverage**: Added a parameterized test case to validate the update compatibility behavior of `TaggedOutput` annotations in `DoFn` process methods, confirming the expected type inference for both older and newer compatibility settings. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/python/apache_beam/typehints/decorators.py** * Imported `get_pipeline_options` to enable compatibility version checks. * Added a compatibility check within `extract_tagged_outputs` to preserve old behavior for versions prior to 2.72.0. * Modified the `extract_tagged_outputs` logic to correctly identify and handle bare `TaggedOutput` types in unions and to avoid re-extracting tags that are already explicitly defined. * **sdks/python/apache_beam/typehints/tagged_output_typehints_test.py** * Added imports for `param`, `parameterized`, `PipelineOptions`, and `Any` to support new test cases. * Implemented a new parameterized test `test_pardo_annotation_process_method_update_compatible` to verify `TaggedOutput` annotation behavior under different update compatibility settings. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
