damccorm commented on code in PR #37584: URL: https://github.com/apache/beam/pull/37584#discussion_r2805623461
########## sdks/python/apache_beam/coders/coder_impl.py: ########## @@ -131,6 +131,13 @@ Observables = List[Tuple[observable.ObservableMixin, 'CoderImpl']] +def as_nested_size(unnested_size, nested): + if nested: + return unnested_size + get_varint_size(unnested_size) + else: + return unnested_size Review Comment: I think this is the same as https://github.com/apache/beam/blob/eba1ec36adcac85d37ab7ea25986ebeec3dada47/sdks/python/apache_beam/coders/coder_impl.py#L191 so we can just use that helper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
