chadrik commented on a change in pull request #12881:
URL: https://github.com/apache/beam/pull/12881#discussion_r492498856
##########
File path: sdks/python/apache_beam/runners/worker/data_plane.py
##########
@@ -218,7 +249,7 @@ class DataChannel(with_metaclass(abc.ABCMeta, object)): #
type: ignore[misc]
@abc.abstractmethod
def input_elements(self,
instruction_id, # type: str
- expected_inputs, # type: Collection[str]
+ expected_inputs, # type: Sized
Review comment:
we only call `__len__`, but I'm happy to leave it as a collection.
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
