gemini-code-assist[bot] commented on PR #37620: URL: https://github.com/apache/beam/pull/37620#issuecomment-3915116406
## Summary of Changes Hello @derrickaw, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Apache Beam Google Ads IO connector to utilize version 23 of the Google Ads API client library. This update ensures that the connector remains compatible with the latest API features and addresses any deprecations from previous versions, providing users with access to the most current Google Ads functionalities. ### Highlights * **Google Ads API Version Upgrade**: The Google Ads client library dependencies have been upgraded from version 19 to version 23. * **Codebase References Updated**: All internal references within the Google Ads IO connector, including class names, imports, and mock objects, have been updated to reflect the new v23 API. * **File Renaming**: The core implementation file `GoogleAdsV19.java` was renamed to `GoogleAdsV23.java` to align with the new API version. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/java/io/google-ads/build.gradle** * Updated `google-ads` and `google-ads-stubs` dependencies from version 36.0.0 (v19) to 42.0.0 (v23). * **sdks/java/io/google-ads/src/main/java/org/apache/beam/sdk/io/googleads/GoogleAdsIO.java** * Updated Javadoc `@see` tag from `GoogleAdsV19` to `GoogleAdsV23`. * Modified the `current()` method to return `GoogleAdsV23.INSTANCE` instead of `GoogleAdsV19.INSTANCE`. * **sdks/java/io/google-ads/src/main/java/org/apache/beam/sdk/io/googleads/GoogleAdsV19.java** * Renamed the file to `GoogleAdsV23.java`. * Updated all import statements from `v19` to `v23` for Google Ads errors and services. * Changed class name from `GoogleAdsV19` to `GoogleAdsV23` and updated all internal references within the class, including Javadoc, `Read` and `ReadAll` builder calls, and `ReadAllFn` constructor. * **sdks/java/io/google-ads/src/test/java/org/apache/beam/sdk/io/googleads/DummyRateLimitPolicy.java** * Updated the import for `GoogleAdsError` from `v19` to `v23`. * Changed the implemented interface from `GoogleAdsV19.RateLimitPolicy` to `GoogleAdsV23.RateLimitPolicy`. * **sdks/java/io/google-ads/src/test/java/org/apache/beam/sdk/io/googleads/GoogleAdsIOTest.java** * Updated all import statements for Google Ads errors and services from `v19` to `v23`. * Modified references to `GoogleAdsV19.ReadAll.ReadAllFn.sleeper` to `GoogleAdsV23.ReadAll.ReadAllFn.sleeper`. * Updated mock service stub references from `GOOGLE_ADS_SERVICE_STUB_V19` to `GOOGLE_ADS_SERVICE_STUB_V23`. * Adjusted the expected exception message to reflect `v23` errors. * **sdks/java/io/google-ads/src/test/java/org/apache/beam/sdk/io/googleads/MockGoogleAdsClientFactory.java** * Updated import statements for Google Ads services and stubs from `v19` to `v23`. * Renamed the static mock stub from `GOOGLE_ADS_SERVICE_STUB_V19` to `GOOGLE_ADS_SERVICE_STUB_V23`. * Modified the `newGoogleAdsClient` method to use `googleAdsClient.getVersion23()` instead of `getVersion19()`. </details> <details> <summary><b>Activity</b></summary> * No human activity (comments, reviews) was provided in the context for this pull request. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
