gemini-code-assist[bot] commented on code in PR #37313:
URL: https://github.com/apache/beam/pull/37313#discussion_r2817827040
##########
sdks/python/test-suites/portable/common.gradle:
##########
@@ -508,7 +504,7 @@ def addTestJavaJarCreator(String runner, Task
jobServerJarTask) {
}
// TODO(BEAM-11333) Update and test multiple Flink versions.
-addTestJavaJarCreator("FlinkRunner",
tasks.getByPath(":runners:flink:${latestFlinkVersion}:job-server:shadowJar"))
+addTestJavaJarCreator("FlinkRunner",
tasks.getByPath(":runners:flink:${latestFlink1Version}:job-server:shadowJar"))
Review Comment:
This change pins `addTestJavaJarCreator` for Flink to `latestFlink1Version`
('1.20'), but the `addTestFlinkUberJar` function (defined on line 510) still
uses `latestFlinkVersion`, which will be Flink 2.0.
The `testPipelineJarFlinkRunner` task depends on artifacts from both, which
could lead to a version mismatch. Should `addTestFlinkUberJar` also be pinned
to `latestFlink1Version` for consistency, or perhaps a new set of uber jar
tasks should be created for Flink 2.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
