gemini-code-assist[bot] commented on PR #37630: URL: https://github.com/apache/beam/pull/37630#issuecomment-3917483335
## Summary of Changes Hello @tarun-google, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Terraform configuration for the Envoy RateLimiter by introducing greater flexibility and better resource management. It allows for conditional deployment of the StatsD exporter, centralizes all Kubernetes resources under a dedicated namespace, and updates documentation to reflect broader language support, enhancing the overall deployability and maintainability of the rate limiting service. ### Highlights * **Dynamic StatsD Exporter Deployment**: The StatsD exporter sidecar for Prometheus metrics is now deployed dynamically, controlled by a new `enable_statsd` variable. This allows users to optionally enable or disable metrics collection, with a default of `false`. * **Kubernetes Namespace Integration**: All Kubernetes resources for the Envoy RateLimiter are now deployed within a configurable Kubernetes namespace, defaulting to `envoy-ratelimiter`. This improves resource organization and isolation within the GKE cluster. * **Updated Documentation and Default Log Level**: The `README.md` has been updated to include examples for Beam Java pipelines using the rate limiter. Additionally, the default log level for the ratelimit service has been changed from `debug` to `info` for less verbose logging by default. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **examples/terraform/envoy-ratelimiter/README.md** * Updated the 'Example Beam Pipelines' section to differentiate between Python and Java examples. * Added a new example link for a Beam Java pipeline. * Introduced `namespace` and `enable_statsd` variables to the configuration table. * **examples/terraform/envoy-ratelimiter/gke.tf** * Adjusted inline comments for `enable_private_nodes` and `enable_private_endpoint` for consistent formatting. * **examples/terraform/envoy-ratelimiter/ratelimit.tf** * Added a new `kubernetes_namespace` resource to create a dedicated namespace for the rate limiter components. * Updated `kubernetes_config_map`, `kubernetes_deployment` (redis, ratelimit), `kubernetes_service` (redis, ratelimit, ratelimit_external), and `kubernetes_horizontal_pod_autoscaler_v2` resources to specify the new `namespace` variable in their metadata. * Modified `depends_on` clauses for several resources to depend on the newly created `kubernetes_namespace.ratelimit_namespace` instead of `time_sleep.wait_for_cluster`. * Changed the `USE_STATSD` environment variable for the ratelimit container to be conditional based on `var.enable_statsd`. * Added a `LOG_FORMAT` environment variable with a default value of `json` to the ratelimit container. * Converted the `statsd-exporter` container block into a dynamic block, making its deployment conditional on `var.enable_statsd`. * Converted the `port` blocks within the dynamic `statsd-exporter` container to also be dynamic, conditional on `var.enable_statsd`. * **examples/terraform/envoy-ratelimiter/variables.tf** * Added a new `namespace` variable to define the Kubernetes namespace for deployment. * Added a new boolean `enable_statsd` variable to control the deployment of the statsd-exporter sidecar. * Changed the default value of `ratelimit_log_level` from `debug` to `info`. </details> <details> <summary><b>Activity</b></summary> * No human activity has occurred on this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
