shunping commented on code in PR #37536:
URL: https://github.com/apache/beam/pull/37536#discussion_r2824298168
##########
sdks/python/apache_beam/utils/processes.py:
##########
@@ -52,11 +65,12 @@ def call(*args, **kwargs):
except OSError as e:
raise RuntimeError("Executable {} not found".format(args[0])) from e
except subprocess.CalledProcessError as error:
- if isinstance(args, tuple) and (args[0][2] == "pip"):
Review Comment:
As mentioned in the other comments, I think we can remove this entire "if"
block (and two similar ones below) so we can get rid of the index error and
also avoid parsing the package name from the argument list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
