arunpandianp commented on code in PR #37604:
URL: https://github.com/apache/beam/pull/37604#discussion_r2827072262
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillTagEncodingV1.java:
##########
@@ -159,17 +155,21 @@ public TimerData windmillTimerToTimerData(
// - the Global StateNamespace is different, and becomes "/"
// - the id is totally arbitrary; currently unescaped though that could
change
- ByteString tag = timer.getTag();
- checkArgument(
- tag.startsWith(prefix.byteString()),
- "Expected timer tag %s to start with prefix %s",
- tag,
- prefix.byteString());
+ ByteString tag =
ByteString.copyFrom(timer.getTag().asReadOnlyByteBuffer());
Review Comment:
we don't need the copy here, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
