kennknowles commented on PR #37342:
URL: https://github.com/apache/beam/pull/37342#issuecomment-3935813426
I don't really remember the design well enough to quickly review just the
diff. I would need to read the whole IO to understand the intent. Maybe @Abacn
knows better than me. I have a couple questions / comments
- Who is doing the retrying? Why are they not retrying the
UserCodeException? Should they be? if it is inside the RRIO then how did it get
wrapped into UserCodeException? If it is the runner, then UserCodeException is
usually the correct way to pass the info to the runner. I just don't know the
design here.
- It seems very odd (like, something I've never seen in any code) to
traverse the whole causal chain. I feel there must be a more straightforward
thing we should do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
