Abacn commented on code in PR #37560:
URL: https://github.com/apache/beam/pull/37560#discussion_r2834960793
##########
sdks/python/setup.py:
##########
@@ -574,8 +574,9 @@ def get_portability_package_data():
'docstring-parser>=0.15,<1.0',
'jinja2>=3.0,<3.2',
'virtualenv-clone>=0.5,<1.0',
- # https://github.com/PiotrDabkowski/Js2Py/issues/317
- 'js2py>=0.74,<1; python_version<"3.12"',
+ # pythonmonkey is used for Javascript mapping support
+ # Please install NPM and Node.js before installing PythonMonkey.
+ 'pythonmonkey>=1.3.0; python_version>="3.8"',
Review Comment:
> Please install NPM and Node.js before installing PythonMonkey
This introduced a heavy prerequisite (whole node.js ecosystem) for Beam. Not
sure worth it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
