MansiSingh17 commented on PR #37672: URL: https://github.com/apache/beam/pull/37672#issuecomment-3939778993
Hi @mtauha, thanks for the detailed review! I've addressed all 4 points: 1. skip_due_to_30778 flag — This was already set to False in the PR, so tests are running and verified by CI. 2. groupby_attr_expr.py unconditional beam.Map(print) — Fixed, moved inside an else block and if test block moved inside the with beam.Pipeline() context. 3. Missing [START/END] markers — The markers are intact in both groupby_attr_expr.py and groupby_two_exprs.py, doc generation should not be affected. 4. Unnecessary to_grocery_row() helper — Already removed from groupby_simple_aggregate.py. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
