gemini-code-assist[bot] commented on PR #37682: URL: https://github.com/apache/beam/pull/37682#issuecomment-3944166411
## Summary of Changes Hello @stankiewicz, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates an optimization for Kafka Exactly-Once Semantics (EOS) by introducing configurable triggering mechanisms for the Kafka sink. The changes provide greater flexibility in how records are batched and committed, allowing users to tune performance and latency for EOS writes to Kafka based on specific application requirements. This enhancement improves the overall efficiency and adaptability of the Kafka I/O connector. ### Highlights * **Configurable EOS Triggering**: Introduced new configuration options for Kafka Exactly-Once Semantics (EOS) triggering, allowing users to specify batching based on both element count and processing time timeout. * **Enhanced Windowing Logic**: Modified the `KafkaExactlyOnceSink` to use a more flexible windowing trigger (`AfterFirst` with `AfterPane.elementCountAtLeast` and `AfterProcessingTime.pastFirstElementInPane().plusDelayOf`) for committing records, improving control over batch sizes and latency. * **API Extension for EOS Configuration**: Added `withEOSTriggerConfig` methods to `KafkaIO.WriteRecords` and `KafkaIO.Write` to expose the new trigger parameters to users, enabling fine-grained control over EOS behavior. * **Schema and Translation Updates**: Updated the Kafka I/O translation schema and logic to persist and retrieve the new EOS trigger configuration fields (`eos_trigger_num_elements` and `eos_trigger_timeout_ms`), ensuring compatibility and proper serialization. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaExactlyOnceSink.java** * Updated the windowing trigger logic for Kafka Exactly-Once Sink to support configurable batching based on element count and processing time timeout. * Reapplied windowing configuration after assigning sequential IDs to maintain desired batching. * **sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java** * Added new configuration options and methods to `KafkaIO.WriteRecords` and `KafkaIO.Write` for setting the Exactly-Once Semantics (EOS) trigger parameters (number of elements and timeout duration). * Included default values for `eosTriggerNumElements` and `eosTriggerTimeout` in the `WriteRecords` builder. * **sdks/java/io/kafka/upgrade/src/main/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslation.java** * Modified the Kafka I/O translation to include new fields for EOS trigger configuration (`eos_trigger_num_elements` and `eos_trigger_timeout_ms`) in the transform schema and row conversion. * **sdks/java/io/kafka/upgrade/src/test/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslationTest.java** * Updated the test schema mapping for Kafka I/O write transforms to include the newly added EOS trigger configuration fields. </details> <details> <summary><b>Activity</b></summary> * The pull request description indicates this is a cherry-pick from another repository, specifically https://github.com/apache/beam/pull/37648. * Standard contribution guidelines and CI status checks are included in the pull request description. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
