arunpandianp commented on code in PR #37683:
URL: https://github.com/apache/beam/pull/37683#discussion_r2840892544
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java:
##########
@@ -1299,6 +1299,17 @@ public DataflowPipelineJob run(Pipeline pipeline) {
if (shouldActAsStreaming(pipeline)) {
options.setStreaming(true);
+ {
+ List<String> experiments =
+ options.getExperiments() == null
+ ? new ArrayList<>()
+ : new ArrayList<>(options.getExperiments());
+ // Experiment marking that the harness supports tag encoding v2
+ // Backend will enable tag encoding v2 only if the harness supports it.
+ experiments.add("streaming_engine_state_tag_encoding_v2_supported");
Review Comment:
Chatted offline. This change is only marking the beam version as eligible
for the new encoding. There'll be a following change where encoding v2 will be
enabled by default. Will add compatabilityVersion checks in the following
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
