gemini-code-assist[bot] commented on PR #37694: URL: https://github.com/apache/beam/pull/37694#issuecomment-3948265109
## Summary of Changes Hello @derrickaw, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous vulnerability fix by replacing the `pythonmonkey` library with `js2py` for handling JavaScript mapping functions in Beam's YAML module. This change aims to resolve compatibility issues, particularly for Python 3.12 and newer versions, where `pythonmonkey` proved problematic. The update involves refactoring the JavaScript execution logic, adjusting dependencies, and updating associated tests. Additionally, a minor cleanup was performed in the `standard_io.yaml` schema. ### Highlights * **JavaScript Engine Replacement**: The `pythonmonkey` library has been replaced with `js2py` for executing JavaScript mapping functions within Beam's YAML module. This change addresses compatibility issues and aims to improve stability. * **Python 3.12+ Compatibility**: A version constraint for `js2py` has been introduced, limiting its use to Python versions less than 3.12, as `js2py` is not supported on Python 3.12 and later. * **Dependency and Test Updates**: The `setup.py` file was updated to include `js2py` as a dependency, and related test files were modified to reflect the switch from `pythonmonkey` to `js2py` for JavaScript UDFs. * **YAML Schema Adjustment**: The `num_shards` parameter was removed from the `WriteToJson` transform definition in `standard_io.yaml`. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/python/apache_beam/yaml/standard_io.yaml** * Removed the 'num_shards' parameter from the 'WriteToJson' transform definition. * **sdks/python/apache_beam/yaml/yaml_mapping.py** * Removed imports for 'atexit', 'importlib', 'os', 'queue', 'sys', 'threading', and 'uuid' which were related to 'pythonmonkey'. * Removed the 'PythonMonkeyDispatcher' class and its associated logic for managing JavaScript execution in a separate thread. * Removed the 'JavaScriptCallable' class, which previously wrapped 'pythonmonkey' functionality. * Added conditional imports for 'js2py' and 'JsObjectWrapper' to handle cases where 'js2py' might not be installed. * Introduced a '_CustomJsObjectWrapper' class to provide proper pickling support for 'js2py' objects. * Rewrote the '_expand_javascript_mapping_func' function to use 'js2py' for evaluating JavaScript expressions, callables, and files. * Implemented '_js_object_to_py_object' to convert 'js2py' objects into native Python types. * **sdks/python/apache_beam/yaml/yaml_udf_test.py** * Removed the 'importlib' import, as it was no longer needed for 'pythonmonkey' checks. * Replaced checks for 'pythonmonkey' availability ('pm_available') with checks for 'js2py' availability. * Updated '@unittest.skipIf' decorators to skip JavaScript UDF tests if 'js2py' is not installed. * **sdks/python/setup.py** * Added 'js2py>=0.74,<1' as a new dependency for the Python SDK, specifically constrained to 'python_version<"3.12"'. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
