ibzib commented on a change in pull request #12905:
URL: https://github.com/apache/beam/pull/12905#discussion_r493004974
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -105,9 +106,11 @@ def submit(self, proto_pipeline):
Submit and run the pipeline defined by `proto_pipeline`.
"""
prepare_response = self.prepare(proto_pipeline)
+ artifact_endpoint = (self.artifact_endpoint
Review comment:
You will need to correct the formatting here:
```
12:35:40 - artifact_endpoint = (self.artifact_endpoint
12:35:40 - or
prepare_response.artifact_staging_endpoint.url)
12:35:40 + artifact_endpoint = (
12:35:40 + self.artifact_endpoint or
12:35:40 + prepare_response.artifact_staging_endpoint.url)
```
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -105,9 +106,11 @@ def submit(self, proto_pipeline):
Submit and run the pipeline defined by `proto_pipeline`.
"""
prepare_response = self.prepare(proto_pipeline)
+ artifact_endpoint = (self.artifact_endpoint
Review comment:
Can we add a test for this to prevent future regressions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
