gemini-code-assist[bot] commented on PR #37744: URL: https://github.com/apache/beam/pull/37744#issuecomment-3990126923
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the codebase to exclusively use JodaTime's static factory methods for `Instant` creation, moving away from direct constructor calls. This enhancement primarily targets improved code clarity and adherence to recommended API usage patterns, particularly within test environments where `Instant` objects are frequently instantiated. ### Highlights * **JodaTime Constructor Usage**: Replaced direct calls to `new Instant(long)` constructors with the more explicit and less ambiguous `Instant.ofEpochMilli(long)` static factory method across numerous files. * **Code Clarity and Best Practices**: The change aligns with best practices for JodaTime, as recommended by tools like Error Prone, to avoid potential ambiguities and improve code readability. * **Test Code Refinement**: The majority of modifications are concentrated within test files, ensuring that test setups and assertions correctly reflect the intended timestamp creation without relying on potentially ambiguous constructors. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **examples/java/src/test/java/org/apache/beam/examples/complete/AutoCompleteTest.java** * Updated `TimestampedValue.of` calls to use `Instant.ofEpochMilli`. * **examples/java/src/test/java/org/apache/beam/examples/complete/game/HourlyTeamScoreTest.java** * Changed `startMinTimestamp` initialization to use `Instant.ofEpochMilli`. * **examples/java/src/test/java/org/apache/beam/examples/complete/game/LeaderBoardTest.java** * Modified `baseTime` initialization to use `Instant.ofEpochMilli`. * **examples/java/src/test/java/org/apache/beam/examples/complete/game/StatefulTeamScoreTest.java** * Updated `baseTime` initialization to use `Instant.ofEpochMilli`. * **examples/java/src/test/java/org/apache/beam/examples/cookbook/TriggerExampleTest.java** * Adjusted `TimestampedValue.of` calls to use `Instant.ofEpochMilli`. * **model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml** * Updated Java code snippets in comments to reflect `Instant.ofEpochMilli` usage. * **runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/AfterDelayFromFirstElementStateMachine.java** * Replaced `new Instant(0)` with `Instant.ofEpochMilli(0)` in `alignedTo` method. * **runners/core-java/src/test/java/org/apache/beam/runners/core/InMemoryTimerInternalsTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `TimerData` creation and watermark advancement. * **runners/core-java/src/test/java/org/apache/beam/runners/core/KeyedWorkItemCoderTest.java** * Updated `TimerData.of` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/LateDataDroppingDoFnRunnerTest.java** * Changed mock for `currentInputWatermarkTime()` to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/LateDataUtilsTest.java** * Modified `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/ReduceFnRunnerTest.java** * Updated `IntervalWindow` creation, watermark advancements, and element injection to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/SideInputHandlerTest.java** * Changed `IntervalWindow` creation and `valuesInWindow` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for timer data and timestamped value creation. * **runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java** * Updated `IntervalWindow` constants and `WindowedValue` creation to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/StateInternalsTest.java** * Modified `WatermarkHoldState.add` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/StatefulDoFnRunnerTest.java** * Changed `IntervalWindow` constants and `Instant` initializations to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/TimerInternalsTest.java** * Updated `TimerData.of` calls and `Instant` initializations to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/WindowMatchersTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` in `timestampedValueInGlobalWindow` calls. * **runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/MonitoringInfoEncodingsTest.java** * Changed `GaugeData.create` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/AfterAllStateMachineTest.java** * Updated `IntervalWindow` creation and `advanceInputWatermark` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/AfterEachStateMachineTest.java** * Modified `IntervalWindow` creation and `advanceInputWatermark` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/AfterFirstStateMachineTest.java** * Changed `IntervalWindow` creation and `advanceInputWatermark` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/AfterPaneStateMachineTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `IntervalWindow` creation. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/AfterProcessingTimeStateMachineTest.java** * Updated `advanceProcessingTime` calls and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/AfterSynchronizedProcessingTimeStateMachineTest.java** * Modified `advanceProcessingTime` calls and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/AfterWatermarkStateMachineTest.java** * Changed `IntervalWindow` creation and `advanceInputWatermark` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/DefaultTriggerStateMachineTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `IntervalWindow` creation and `advanceInputWatermark` calls. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/NeverStateMachineTest.java** * Updated `TimestampedValue.of` and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/OrFinallyStateMachineTest.java** * Modified `IntervalWindow` creation and `advanceInputWatermark` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/RepeatedlyStateMachineTest.java** * Changed `IntervalWindow` creation and `advanceProcessingTime` calls to use `Instant.ofEpochMilli`. * **runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/ReshuffleTriggerStateMachineTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `IntervalWindow` creation. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/CopyOnAccessInMemoryStateInternalsTest.java** * Updated `WatermarkHoldState.add` calls and `BoundedWindow.maxTimestamp` mocks to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/DirectTimerInternalsTest.java** * Changed `MockClock.fromInstant` and `TimerData.of` calls to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java** * Modified `TimerData.of` calls to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/EvaluationContextTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `TestBoundedWindow` creation, `WindowedValues.of` calls, and `StepTransformResult.withHold` calls. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/FlattenEvaluatorFactoryTest.java** * Updated `timestampedValueInGlobalWindow` calls to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/ImmutabilityCheckingBundleFactoryTest.java** * Changed `WindowedValue.of` calls to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/ImmutableListBundleFactoryTest.java** * Modified `timestampedValueInGlobalWindow` and `WindowedValue.of` calls to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/KeyedPValueTrackingVisitorTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` in `WindowedValues.of` calls. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/MultiStepCombineTest.java** * Updated `TimestampedValue.of` and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/ParDoEvaluatorTest.java** * Changed `IntervalWindow` creation and `WindowedValues.of` calls to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/SideInputContainerTest.java** * Modified `BoundedWindow.maxTimestamp` mocks and `WindowedValues.of` calls to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/StatefulParDoEvaluatorFactoryTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `IntervalWindow` creation and `WindowedValue.of` calls. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/TestStreamEvaluatorFactoryTest.java** * Updated `advanceWatermarkTo` and `getTimestamp` assertions to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/WatermarkCallbackExecutorTest.java** * Changed `IntervalWindow` creation and `fireForWatermark` calls to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/WatermarkManagerTest.java** * Modified `MockClock.fromInstant`, `timestampedBundle` calls, and `TransformWatermarks` assertions to use `Instant.ofEpochMilli`. * **runners/direct-java/src/test/java/org/apache/beam/runners/direct/WindowEvaluatorFactoryTest.java** * Replaced `EPOCH` constant, `WindowedValue` creation, and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/CustomMetricQueryResults.java** * Updated `GaugeResult.create` calls to use `Instant.ofEpochMilli`. * **runners/flink/2.0/src/test/java/org/apache/beam/runners/flink/FlinkSavepointTest.java** * Changed `timer.set` calls to use `Instant.ofEpochMilli`. * **runners/flink/2.0/src/test/java/org/apache/beam/runners/flink/streaming/FlinkStateInternalsTest.java** * Modified `IntervalWindow` creation and `WatermarkHoldState.add` calls to use `Instant.ofEpochMilli`. * **runners/flink/src/test/java/org/apache/beam/runners/flink/FlinkSavepointTest.java** * Changed `timer.set` calls to use `Instant.ofEpochMilli`. * **runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/FlinkStateInternalsTest.java** * Modified `IntervalWindow` creation and `WatermarkHoldState.add` calls to use `Instant.ofEpochMilli`. * **runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperatorTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for timer timestamp initialization, `timer.withOutputTimestamp` calls, `IntervalWindow` creation, and `WindowedValues.of` calls. * **runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperatorTest.java** * Updated `IntervalWindow` creation and `timerTarget` initialization to use `Instant.ofEpochMilli`. * **runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/WindowDoFnOperatorTest.java** * Changed `IntervalWindow` creation and `WindowedValues.of` calls to use `Instant.ofEpochMilli`. * **runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/stableinput/BufferedElementsTest.java** * Modified `WindowedValues.of` and `BufferedElements.Timer` creation to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/BatchViewOverridesTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `IntervalWindow` creation and `WindowedValues.of` calls. * **runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineJobTest.java** * Updated `separatingTimestamp` initialization to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/TimeUtilTest.java** * Changed `toCloudTime` and `fromCloudTime` assertions to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/GroupingShuffleReaderTest.java** * Modified `timestamp` initialization to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `IntervalWindow` creation and `WindowedValue` creation. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/PartitioningShuffleReaderTest.java** * Updated `timestamp` initialization to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/PubsubReaderTest.java** * Changed `timestampedValueInGlobalWindow` calls to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/PubsubSinkTest.java** * Modified `timestampedValueInGlobalWindow` calls to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/ReifyTimestampAndWindowsParDoFnFactoryTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `IntervalWindow` creation and `WindowedValues.of` calls. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/ShuffleSinkTest.java** * Updated `timestamp` initialization to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java** * Changed `IntervalWindow` constants to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingGroupAlsoByWindowFnsTest.java** * Modified `currentInputWatermarkTime` mock, `addElement` calls, and `addTimer` calls to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingGroupAlsoByWindowsReshuffleDoFnTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `addElement` calls and `item.getTimestamp()` assertions. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingKeyedWorkItemSideInputDoFnRunnerTest.java** * Updated `currentInputWatermarkTime` mock, `timerData` calls, and `elementTime` initialization to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContextTest.java** * Changed `Watermarks.builder().setInputDataWatermark` and `TimerData.of` calls to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingSideInputDoFnRunnerTest.java** * Modified `IntervalWindow` creation and `watermarkHold.add` calls to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/UngroupedShuffleReaderTest.java** * Replaced `timestamp` initialization to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/UserParDoFnFactoryTest.java** * Updated `IntervalWindow` creation and `WindowedValues.of` calls to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WindmillKeyedWorkItemTest.java** * Changed `IntervalWindow` constants and `WindowedValues.of` calls to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WindmillTimeUtilsTest.java** * Modified `windmillToHarnessWatermark` and `harnessToWindmillTimestamp` assertions to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `Watermarks.builder().setInputDataWatermark` calls. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/util/BatchGroupAlsoByWindowReshuffleDoFnTest.java** * Updated `WindowedValues.of` calls and `item.getTimestamp()` assertions to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/util/GroupAlsoByWindowProperties.java** * Changed `WindowedValues.of` calls and `item.getTimestamp()` assertions to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillServerTest.java** * Modified `inputDataWatermark` and `synchronizedProcessingTime` assertions to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillStateInternalsTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `WatermarkHoldState.add` calls and `waitAndSet` calls. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillStateReaderTest.java** * Updated `result` and `watermarkFuture.get()` assertions to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillTagEncodingV1Test.java** * Changed `IntervalWindow` creation and `TEST_TIMESTAMPS` list to use `Instant.ofEpochMilli`. * **runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillTagEncodingV2Test.java** * Modified `INTERVAL_WINDOW` constant and `TimerData.of` calls to use `Instant.ofEpochMilli`. * **runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaTransformMetricsRegistry.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `BoundedWindow.maxTimestamp` mocks. * **runners/samza/src/test/java/org/apache/beam/runners/samza/runtime/GroupByKeyOpTest.java** * Updated `TestStream.create` calls to use `Instant.ofEpochMilli`. * **runners/samza/src/test/java/org/apache/beam/runners/samza/runtime/SamzaTimerInternalsFactoryTest.java** * Changed `TimerInternals.TimerData.of` calls and `setInputWatermark` calls to use `Instant.ofEpochMilli`. * **runners/samza/src/test/java/org/apache/beam/runners/samza/util/PipelineJsonRendererTest.java** * Modified `Create.timestamped` calls to use `Instant.ofEpochMilli`. * **runners/spark/3/src/test/java/org/apache/beam/runners/spark/structuredstreaming/translation/batch/CombineGloballyTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` in `Create.timestamped` calls. * **runners/spark/3/src/test/java/org/apache/beam/runners/spark/structuredstreaming/translation/batch/CombinePerKeyTest.java** * Updated `Create.timestamped` calls to use `Instant.ofEpochMilli`. * **runners/spark/3/src/test/java/org/apache/beam/runners/spark/structuredstreaming/translation/batch/GroupByKeyTest.java** * Changed `Create.timestamped` calls to use `Instant.ofEpochMilli`. * **runners/spark/3/src/test/java/org/apache/beam/runners/spark/structuredstreaming/translation/batch/WindowAssignTest.java** * Modified `Create.timestamped` calls to use `Instant.ofEpochMilli`. * **runners/spark/src/main/java/org/apache/beam/runners/spark/io/CreateStream.java** * Replaced `new Instant(0)` with `Instant.ofEpochMilli(0)` in `CreateStream.of` method. * **runners/spark/src/main/java/org/apache/beam/runners/spark/stateful/SparkTimerInternals.java** * Updated `new Instant(0)` with `Instant.ofEpochMilli(0)` in `SparkTimerInternals` constructor. * **runners/spark/src/test/java/org/apache/beam/runners/spark/GlobalWatermarkHolderTest.java** * Changed `instant` initialization to use `Instant.ofEpochMilli(0)`. * **runners/spark/src/test/java/org/apache/beam/runners/spark/aggregators/metrics/sink/SparkMetricsSinkTest.java** * Modified `instant` initialization to use `Instant.ofEpochMilli(0)`. * **runners/spark/src/test/java/org/apache/beam/runners/spark/metrics/SparkMetricsPusherTest.java** * Replaced `instant` initialization to use `Instant.ofEpochMilli(0)`. * **runners/spark/src/test/java/org/apache/beam/runners/spark/translation/AbstractInOutIteratorTest.java** * Updated `TEST_TIMESTAMP` and `TEST_OUTPUT_TIMESTAMP` constants to use `Instant.ofEpochMilli`. * **runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/CreateStreamTest.java** * Changed `instant` initialization, `advanceWatermarkForNextBatch` calls, and `TimestampedValue.of` calls to use `Instant.ofEpochMilli`. * **runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/ResumeFromCheckpointStreamingTest.java** * Modified `produce` calls and `run` calls to use `Instant.ofEpochMilli`. * **runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/SparkCoGroupByKeyStreamingTest.java** * Replaced `instant` initialization to use `Instant.ofEpochMilli(0)`. * **runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/StatefulStreamingParDoEvaluatorTest.java** * Updated `instant` initialization to use `Instant.ofEpochMilli(0)`. * **runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/StreamingTransformTranslatorTest.java** * Changed `baseTimestamp` initialization to use `Instant.ofEpochMilli(0)`. * **runners/spark/src/test/java/org/apache/beam/runners/spark/util/TimerUtilsTest.java** * Modified `NOW` constant to use `Instant.ofEpochMilli(1000L)`. * **sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/GaugeResult.java** * Replaced `EPOCH` constant with `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/AfterProcessingTime.java** * Updated `alignedTo` method to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/TimestampTransform.java** * Changed `alignTo` method to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/coders/TimestampPrefixingWindowCoderTest.java** * Modified `CustomWindow` and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java** * Replaced `startInstant` initialization with `Instant.ofEpochMilli(0L)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/SchemaTranslationTest.java** * Updated `simpleRow` call to use `Instant.ofEpochMilli(23L)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/state/StateContextsTest.java** * Changed `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java** * Modified `TimestampedValue.of` and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PaneExtractorsTest.java** * Replaced `new Instant(0L)` with `Instant.ofEpochMilli(0L)` in `ValueInSingleWindow.of` calls. * **sdks/java/core/src/test/java/org/apache/beam/sdk/testing/StaticWindowsTest.java** * Updated `first` initialization to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/testing/TestStreamTest.java** * Changed `instant` initialization, `TimestampedValue.of` calls, `advanceWatermarkTo` calls, and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java** * Modified `Create.timestamped` calls to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CreateTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` in `TimestampedValue.of` calls. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DeduplicateTest.java** * Updated `base` initialization to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DistinctTest.java** * Changed `base` initialization to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java** * Modified `TimestampedValue.of` calls and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupByKeyTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `TestStream.create` calls, `Create.timestamped` calls, and `IntervalWindow` creation. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupIntoBatchesTest.java** * Updated `startInstant` initialization to use `Instant.ofEpochMilli(0L)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/LatestFnTest.java** * Changed `INSTANT` constant to use `Instant.ofEpochMilli(100)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/LatestTest.java** * Modified `Create.timestamped` calls to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MapViewTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `Create.timestamped` calls and `Window.into` calls. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java** * Updated `advanceWatermarkTo` calls, `TimestampedValue.of` calls, `timer.withOutputTimestamp` calls, and `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/RedistributeTest.java** * Changed `Create.timestamped` calls and `WindowedValues.of` calls to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ReifyTest.java** * Modified `Create.of` calls, `Create.timestamped` calls, `TestStream.create` calls, and `ValueInSingleWindow.of` calls to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ReifyTimestampsTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `Create.of` calls, `Create.timestamped` calls, and `ValueInSingleWindow.of` calls. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/AfterAllTest.java** * Updated `IntervalWindow` creation to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/AfterEachTest.java** * Changed `IntervalWindow` creation to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/AfterFirstTest.java** * Modified `IntervalWindow` creation to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/AfterPaneTest.java** * Replaced `new Instant(0)` with `Instant.ofEpochMilli(0)` in `IntervalWindow` creation. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/AfterProcessingTimeTest.java** * Updated `IntervalWindow` creation to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/AfterSynchronizedProcessingTimeTest.java** * Changed `IntervalWindow` creation to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/CalendarWindowsTest.java** * Modified `BoundedWindow.maxTimestamp` mock to use `Instant.ofEpochMilli(100L)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/DefaultTriggerTest.java** * Replaced `new Instant(0)` with `Instant.ofEpochMilli(0)` in `IntervalWindow` creation. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/FixedWindowsTest.java** * Updated `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/IntervalWindowTest.java** * Changed `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/NeverTest.java** * Modified `IntervalWindow` creation to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/OrFinallyTriggerTest.java** * Replaced `new Instant(0)` with `Instant.ofEpochMilli(0)` in `IntervalWindow` creation. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/RepeatedlyTest.java** * Updated `IntervalWindow` creation to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/SessionsTest.java** * Changed `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/SlidingWindowsTest.java** * Modified `IntervalWindow` creation to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `Create.timestamped` calls and `IntervalWindow` creation. * **sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowingTest.java** * Updated `Create.timestamped` calls to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/util/RowStringInterpolatorTest.java** * Changed `ValueInSingleWindow.of` calls to use `Instant.ofEpochMilli(0)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/util/WindowedValueTest.java** * Modified `timestamp` initialization to use `Instant.ofEpochMilli(1234)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/TestStreamTranslationTest.java** * Replaced `new Instant(...)` with `Instant.ofEpochMilli(...)` for `TestStream.create` calls. * **sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/TimerTest.java** * Updated `FIRE_TIME` and `HOLD_TIME` constants to use `Instant.ofEpochMilli`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/TriggerTranslationTest.java** * Changed `AfterProcessingTime.alignedTo` calls to use `Instant.ofEpochMilli(27)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/UnboundedReadFromBoundedSourceTest.java** * Modified `TimestampedValue.of` calls to use `Instant.ofEpochMilli(1L)`. * **sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/renderer/PipelineDotRendererTest.java** * Replaced `new Instant(1)` with `Instant.ofEpochMilli(1)` in `Create.timestamped` calls. * **sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/renderer/PortablePipelineDotRendererTest.java** * Updated `new Instant(1)` with `Instant.ofEpochMilli(1)` in `Create.timestamped` calls. * **sdks/java/core/src/test/java/org/apache/beam/sdk/values/TimestampedValueTest.java** * Changed `TimestampedValue.of` calls to use `Instant.ofEpochMilli`. * **sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/io/AvroIOTest.java** * Modified `base` initialization and `advanceWatermarkTo` calls to use `Instant.ofEpochMilli(0)`. * **sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/io/AvroSchemaIOProviderTest.java** * Replaced `new Instant(1L)` with `Instant.ofEpochMilli(1L)` in `TimestampedValue.of` calls. * **sdks/java/extensions/ordered/src/test/java/org/apache/beam/sdk/extensions/ordered/OrderedEventProcessorGlobalSequenceTest.java** * Updated `base` initialization to use `Instant.ofEpochMilli(0)`. * **sdks/java/extensions/ordered/src/test/java/org/apache/beam/sdk/extensions/ordered/OrderedEventProcessorPerKeySequenceTest.java** * Changed `base` initialization to use `Instant.ofEpochMilli(0)`. * **sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/test/TestUnboundedTable.java** * Modified `advanceWatermarkTo` call to use `Instant.ofEpochMilli(0)`. * **sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java** * Replaced `current` initialization with `Instant.ofEpochMilli(1561671380000L)`. * **sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslUdfUdafTest.java** * Updated `createAccumulator` and `mergeAccumulators` methods to use `Instant.ofEpochMilli(0L)`. * **sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisReader.java** * Changed `backlogBytesLastCheckTime` initialization to `Instant.ofEpochMilli(0L)`. * **sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/kinesis/EFOKinesisReaderTest.java** * Modified `expectedWatermark` initialization to `Instant.ofEpochMilli(123456L)`. * **sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisReaderTest.java** * Replaced `expectedWatermark` initialization with `Instant.ofEpochMilli(123456L)`. * **sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/ClickHouseWriter.java** * Updated `EPOCH_INSTANT` constant to `Instant.ofEpochMilli(0L)`. * **sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestCommon.java** * Changed `docsBuilder` initialization to `Instant.ofEpochMilli(0)`. * **sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java** * Modified `startInstant` initialization to `Instant.ofEpochMilli(0L)`. * **sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FileLoadsStreamingIT.java** * Replaced `start` initialization with `Instant.ofEpochMilli(0)`. * **sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java** * Updated `start` initialization to `Instant.ofEpochMilli(0)`. * **sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryManagedIT.java** * Changed `PeriodicImpulse.create` calls to use `Instant.ofEpochMilli`. * **sdks/java/io/hadoop-format/src/test/java/org/apache/beam/sdk/io/hadoop/format/HadoopFormatIOSequenceFileTest.java** * Modified `START_TIME` constant to `Instant.ofEpochMilli(0)`. * **sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/IcebergIOWriteTest.java** * Replaced `stream` initialization with `Instant.ofEpochMilli(0)`. * **sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/IcebergWriteSchemaTransformProviderTest.java** * Updated `first` initialization to `Instant.ofEpochMilli(0)`. * **sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/unit/write/StreamingWriteTest.java** * Changed `START_TIME` constant to `Instant.ofEpochMilli(0)`. * **sdks/java/io/synthetic/src/main/java/org/apache/beam/sdk/io/synthetic/SyntheticWatermark.java** * Modified `watermark` initialization to `Instant.ofEpochMilli(0)`. * **sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkUtils.java** * Replaced `BEGINNING_OF_TIME` constant with `Instant.ofEpochMilli(0)`. * **sdks/java/testing/nexmark/src/test/java/org/apache/beam/sdk/nexmark/queries/sql/SqlQuery0Test.java** * Updated `BID1` and `BID2` initialization to use `Instant.ofEpochMilli`. * **sdks/java/testing/nexmark/src/test/java/org/apache/beam/sdk/nexmark/queries/sql/SqlQuery1Test.java** * Changed `BID1_USD`, `BID2_USD`, `BID1_EUR`, and `BID2_EUR` initialization to use `Instant.ofEpochMilli`. * **website/www/site/content/en/blog/test-stream.md** * Modified code snippets to use `Instant.ofEpochMilli(0L)`. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
