gemini-code-assist[bot] commented on PR #37748: URL: https://github.com/apache/beam/pull/37748#issuecomment-3990886762
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the stability and reliability of Apache Beam's Java runners and SDK components by implementing more robust `OutOfMemoryError` handling. By explicitly rethrowing OOMs, the system ensures that these critical JVM errors are not inadvertently suppressed or wrapped, which could lead to unpredictable behavior or a corrupted state. This change allows the JVM to respond appropriately to severe memory exhaustion, preventing potential data loss or system crashes and contributing to more resilient pipeline execution. ### Highlights * **Explicit OutOfMemoryError Handling**: Introduced explicit `catch (OutOfMemoryError oom)` blocks in numerous locations across the codebase to ensure that `OutOfMemoryError`s are immediately rethrown. This prevents them from being caught by more general `catch (Throwable)` or `catch (Exception)` blocks, which could otherwise mask critical memory issues and lead to an unstable JVM state. * **Refined Exception Catching**: Adjusted some `try-catch` blocks to specifically handle `RuntimeException` and `OutOfMemoryError` together, or to broaden a `catch (Exception)` to `catch (Throwable)` (after the OOM catch) to ensure comprehensive error handling without swallowing critical JVM errors. * **Minor Codebase Improvements**: Included a minor typo correction in a comment within `MemoryMonitor.java` for improved clarity. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java** * Added explicit `OutOfMemoryError` catch and rethrow in `startBundle()`. * Modified `invokeProcessElement()` to explicitly catch and rethrow `OutOfMemoryError`, and changed the subsequent catch from `Exception` to `Throwable`. * Added explicit `OutOfMemoryError` catch and rethrow in `finishBundle()`. * **runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRunner.java** * Refactored exception handling in `run()` to catch and rethrow `RuntimeException` and `OutOfMemoryError` in a combined block, removing a redundant `instanceof` check. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchDataflowWorker.java** * Added explicit `OutOfMemoryError` catch and rethrow in `doWork()` before the generic `Throwable` catch. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/GroupAlsoByWindowFnRunner.java** * Refactored exception handling in `invokeProcessElement()` to explicitly catch `RuntimeException` before `Exception`, removing an `instanceof` check. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/GroupAlsoByWindowsParDoFn.java** * Added explicit `OutOfMemoryError` catch and rethrow within the output processing lambda in `createRunner()`. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSources.java** * Added explicit `OutOfMemoryError` catch and rethrow in `getReaderProgress()` for fraction consumed, consumed parallelism, and remaining parallelism estimations. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandler.java** * Changed the catch block in `reportFailure()` from `Throwable` to `Exception`. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/JfrInterop.java** * Added explicit `OutOfMemoryError` catch and rethrow in the static initializer block. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/MemoryMonitor.java** * Corrected a typo in a comment from 'risk' to 'risky'. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/BatchingShuffleEntryReader.java** * Modified `fillEntries()` to catch and rethrow `RuntimeException` and `OutOfMemoryError` in a combined block. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/WorkProgressUpdater.java** * Added explicit `OutOfMemoryError` catch and rethrow in `tryCheckpointIfNeeded()` and `reportProgress()`. * **runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingCommitFinalizer.java** * Added explicit `OutOfMemoryError` catch and rethrow within the `finalizeCommit` runnable in `finalizeCommits()`. * **runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/ArtifactStagingService.java** * Added explicit `OutOfMemoryError` catch and rethrow in `onNext()` when getting the completion future result. * **runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/ReferenceCountingExecutableStageContextFactory.java** * Added explicit `OutOfMemoryError` catch and rethrow in `release()` when closing the `ExecutableStageContext`. * **runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/EmbeddedEnvironmentFactory.java** * Added explicit `OutOfMemoryError` catch and rethrow within the `fnHarness.get()` runnable in `createEnvironment()`. * **sdks/java/core/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataOutboundAggregator.java** * Added explicit `OutOfMemoryError` catch and rethrow in `flush()`. * **sdks/java/core/src/main/java/org/apache/beam/sdk/options/ValueProvider.java** * Added explicit `OutOfMemoryError` catch and rethrow in the `get()` method. * **sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateUnique.java** * Added explicit `OutOfMemoryError` catch and rethrow in `addInput()`. * **sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/display/DisplayData.java** * Added explicit `OutOfMemoryError` catch and rethrow in `include()`. * **sdks/java/core/src/main/java/org/apache/beam/sdk/util/MoreFutures.java** * Added explicit `OutOfMemoryError` catch and rethrow in `supplyAsync()` and `runAsync()`. * **sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java** * Added explicit `OutOfMemoryError` catch and rethrow in `outputTo()`. * **sdks/java/harness/src/main/java/org/apache/beam/fn/harness/SplittablePairWithRestrictionDoFnRunner.java** * Added explicit `OutOfMemoryError` catch and rethrow in `outputTo()`. * **sdks/java/harness/src/main/java/org/apache/beam/fn/harness/SplittableSplitAndSizeRestrictionsDoFnRunner.java** * Added explicit `OutOfMemoryError` catch and rethrow in `outputTo()`. * **sdks/java/harness/src/main/java/org/apache/beam/fn/harness/SplittableTruncateSizedRestrictionsDoFnRunner.java** * Added explicit `OutOfMemoryError` catch and rethrow in `outputTo()`. * **sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java** * Added explicit `OutOfMemoryError` catch and rethrow in the teardown functions within `discard()`. * **sdks/java/harness/src/main/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClient.java** * Added explicit `OutOfMemoryError` catch and rethrow in `drainQueueToStream()`. * **sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiTimerBundleTracker.java** * Added explicit `OutOfMemoryError` catch and rethrow in `outputTimers()`. </details> <details> <summary><b>Activity</b></summary> * The pull request description includes a standard contribution checklist, indicating steps for the author to follow. * Automated GitHub Actions CI status badges are present, showing the build health for Python, Java, and Go tests on the master branch. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
