aIbrahiim commented on code in PR #37725:
URL: https://github.com/apache/beam/pull/37725#discussion_r2882742731
##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -504,7 +504,7 @@ task vertexAIInferenceTest {
def cmdArgs = mapToArgString(argMap)
exec {
executable 'sh'
- args '-c', ". ${envdir}/bin/activate &&
${runScriptsDir}/run_integration_test.sh $cmdArgs"
+ args '-c', ". ${envdir}/bin/activate && RUN_VERTEX_AI_TESTS=1
${runScriptsDir}/run_integration_test.sh $cmdArgs"
Review Comment:
previously this RUN_VERTEX_AI_TESTS was read by a
pytest_collection_modifyitems hook in sdks/python/conftest.py which used it to
skip or run tests marked vertex_ai_postcommit and in this PR i removed that
hook and vertex AI tests now decide whether to run based only on whether their
dependencies can be imported as a result nothing reads RUN_VERTEX_AI_TESTS
anymore so setting RUN_VERTEX_AI_TESTS=1 in the gradle task no longer changes
behavior and is effectively a no op, it is harmless but a bit confusing so I
will follow up with a small cleanup to remove that env var from the gradle
config if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
