tvalentyn commented on code in PR #37725: URL: https://github.com/apache/beam/pull/37725#discussion_r2886763420
########## sdks/python/apache_beam/testing/vertex_ai_skip.py: ########## @@ -0,0 +1,38 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Centralized control for Vertex AI integration tests. + +Test modules should use skip_if_vertex_ai_disabled on classes or tests that +require Vertex AI Python dependencies to be installed. +""" + +import pytest + + +def _is_vertex_ai_available() -> bool: + """Return True if Vertex AI client dependencies are importable.""" + try: + import vertexai # pylint: disable=unused-import Review Comment: i would support this if this check was more involved (like, we need the dependency, check credential, check something else, exclude a scenario where the dependency was installed by someother package in advertently, but we really don't want to run this test, etc). For a single import it feels like an overhead to add this decorator ########## sdks/python/apache_beam/testing/vertex_ai_skip.py: ########## @@ -0,0 +1,38 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Centralized control for Vertex AI integration tests. + +Test modules should use skip_if_vertex_ai_disabled on classes or tests that +require Vertex AI Python dependencies to be installed. +""" + +import pytest + + +def _is_vertex_ai_available() -> bool: + """Return True if Vertex AI client dependencies are importable.""" + try: + import vertexai # pylint: disable=unused-import Review Comment: I wonder if we can use https://docs.pytest.org/en/7.1.x/reference/reference.html#pytest-importorskip ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
