PDGGK commented on PR #37530: URL: https://github.com/apache/beam/pull/37530#issuecomment-4017645184
Hi @kennknowles, thanks for the review! I've addressed all three comments in the latest revision: 1. **Removed the catch-all block** — no more `catch (Exception e)` suppressing exceptions. 2. **Switched to TypeDescriptor API** — using `stateType.resolveType()` and `isSubtypeOf()` instead of pulling out raw `Type`/`ParameterizedType`. 3. **Changed LOG.info → LOG.warn** — agreed that WARN is appropriate even for small collections. Could you take another look when you get a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
