shunping commented on code in PR #37799: URL: https://github.com/apache/beam/pull/37799#discussion_r2907729513
########## sdks/python/container/base_image_requirements_manual.txt: ########## @@ -33,6 +33,10 @@ future # google-cloud-profiler is not compatible with python 3.13 (and is not # explicitly compatible with python 3.12) google-cloud-profiler;python_version<="3.12" +# Without google-cloud-profiler at python 3.13+, we need to manually add its +# transitive dependency google-api-python-client as it is required by internal +# tests +google-api-python-client;python_version<="3.13" Review Comment: Sorry, I missed this in my review, but we don't explicitly need this dependency for python 3.10-3.12, because it is a transitive dependency of google-cloud-profiler. However, for python 3.13 and beyond, we get rid of google-cloud-profider, so we need to add this dependency back. I think a better way to add this dependency is `google-api-python-client;python_version>="3.13"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
