stankiewicz commented on PR #37754: URL: https://github.com/apache/beam/pull/37754#issuecomment-4054435491
> So, on the one hand this keep all behavior the same and enables the check. On the other hand... it leaves all the problems the check is meant to prevent. Overall, LGTM since the value of turning on the check is worthwhile. It would be better if the comments explain _why_ ignoring the exception is the right thing to do. agree. some comments are there, especially for interrupt exceptions during teardown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
