stankiewicz commented on code in PR #37851:
URL: https://github.com/apache/beam/pull/37851#discussion_r2932411973
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java:
##########
@@ -284,6 +285,10 @@ public abstract <T> void outputWindowedValue(
Instant timestamp,
Collection<? extends BoundedWindow> windows,
PaneInfo paneInfo);
+
+ public abstract <T> void outputWindowedValue(TupleTag<T> tag,
WindowedValue<T> windowedValue);
+
+ public abstract void outputWindowedValue(WindowedValue<OutputT>
windowedValue);
Review Comment:
@kennknowles I'm really curious if we are able to avoid that. You've spent
quite a lot of time on outputbuilder work to avoid changing public interface
and this method is exposed in ProcessContext so any user can use it if they
want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
