tvalentyn commented on code in PR #37822:
URL: https://github.com/apache/beam/pull/37822#discussion_r2932955415


##########
sdks/python/pyproject.toml:
##########
@@ -21,8 +21,7 @@
 requires = [
     "setuptools",
     "wheel>=0.36.0",
-    "grpcio-tools==1.62.1; python_version <= '3.12'",

Review Comment:
   grpcio-tools==1.62.1 pulls in protobuf 4.
   grpcio-tools==1.71.0 pulls in protobuf 5.
   
   Stubs generated with protobuf 5 won't work with protobuf 4:
   
   ```
   Successfully installed protobuf-4.25.8
   (py310b) 10:58:26 ::python$ python
   Python 3.10.19 (main, Jan  5 2026, 12:29:08) [GCC 14.2.0] on linux
   Type "help", "copyright", "credits" or "license" for more information.
   >>> from google.protobuf import runtime_version
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   ImportError: cannot import name 'runtime_version' from 'google.protobuf' 
(/home/valentyn/.pyenv/versions/py310b/lib/python3.10/site-packages/google/protobuf/__init__.py)
   ```
   
   so if any dependency causes installation of protobuf 4, for example, pip 
install apache-beam[tft], beam stops working.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to