chadrik commented on pull request #12884: URL: https://github.com/apache/beam/pull/12884#issuecomment-696957659
Anything else I should do on this one? On Mon, Sep 21, 2020 at 9:39 PM Robert Bradshaw <[email protected]> wrote: > *@robertwb* approved this pull request. > ------------------------------ > > In sdks/python/apache_beam/coders/coder_impl.py > <https://github.com/apache/beam/pull/12884#discussion_r492465887>: > > > @@ -725,7 +728,7 @@ def __init__(self, key_coder_impl, window_coder_impl): > self._tag_coder_impl = StrUtf8Coder().get_impl() > > def encode_to_stream(self, value, out, nested): > - # type: (dict, create_OutputStream, bool) -> None > + # type: (userstate.Timer, create_OutputStream, bool) -> None > > Hmm... these probably were right at the time. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/12884#pullrequestreview-493117918>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAPOE3FQCUAFBSVMYQRTULSHATARANCNFSM4RTQNRAA> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
