Abacn commented on code in PR #37855:
URL: https://github.com/apache/beam/pull/37855#discussion_r2940565894
##########
sdks/python/apache_beam/typehints/row_type.py:
##########
@@ -91,6 +91,9 @@ def __init__(
# Currently registration happens when converting to schema protos, in
# apache_beam.typehints.schemas
self._schema_id = getattr(self._user_type, _BEAM_SCHEMA_ID, None)
+ if self._schema_id and _BEAM_SCHEMA_ID not in self._user_type.__dict__:
Review Comment:
this part (and another evaluation of _BEAM_SCHEMA_ID in schema.py) fixes
`#2` handle inherited data classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
