kennknowles commented on code in PR #37788:
URL: https://github.com/apache/beam/pull/37788#discussion_r2942449043
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/status/BeamFnStatusClient.java:
##########
@@ -59,6 +59,7 @@ public class BeamFnStatusClient implements AutoCloseable {
private final MemoryMonitor memoryMonitor;
private final Cache<?, ?> cache;
+ @SuppressWarnings({"ThreadPriorityCheck", "nullness"})
Review Comment:
don't suppress nullness
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/UnboundedScheduledExecutorService.java:
##########
@@ -64,6 +64,7 @@
* <li>An unbounded number of threads can be started.
* </ul>
*/
+@SuppressWarnings("NullableTypeParameter")
Review Comment:
Put the annotation directly on the classes that need it, instead of the
encompassing class
##########
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Cache.java:
##########
@@ -40,6 +40,7 @@
/** Transforms for reading and writing request/response associations to a
cache. */
// TODO(damondouglas): Add metrics per
https://github.com/apache/beam/issues/29888.
+@SuppressWarnings("NullableTypeParameter")
Review Comment:
Put annotation directly where it is needed
##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/catalog/hiveutils/ScriptRunner.java:
##########
@@ -34,7 +34,7 @@
*
href="https://github.com/apache/iceberg/blob/main/hive-metastore/src/test/java/org/apache/iceberg/hive/ScriptRunner.java";>Iceberg's
* integration testing</a>
*/
-@SuppressWarnings({"OperatorPrecedence", "DefaultCharset"})
+@SuppressWarnings({"OperatorPrecedence", "DefaultCharset",
"ThreadPriorityCheck"})
Review Comment:
I don't see it - what did I miss?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
