damccorm commented on PR #36081: URL: https://github.com/apache/beam/pull/36081#issuecomment-4092871209
> Hey @damccorm, I have submitted new changes to make that PR in a reviewable state. While I was working on it, there is something I would love to take your thoughts on. There is an open source project named litellm – https://github.com/BerriAI/litellm. We can create one text-embedding client that is compatible with OpenAI formats. That way we can support +100 LLMs (VertexAI, OpenAI, Anthropic, Hugging Face, etc) as stated in their docs without writing more code > > LiteLLM Python SDK: https://docs.litellm.ai/docs/embedding/supported_embedding > > If that is a valid idea, I will change the code to use litellm. Otherwise, I will ensure the CI tests are green before inviting for another look Hey, I missed that this was ready for review at the time - sorry for the later reply. I think this is a good idea for a more generic option - I think we will still likely want an explicit OpenAI option though (it could shell out to this, but it would be nice to have for discoverability/EOU) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
