tvalentyn commented on code in PR #37899:
URL: https://github.com/apache/beam/pull/37899#discussion_r2967766418
##########
sdks/python/apache_beam/transforms/combiners_test.py:
##########
@@ -584,26 +584,68 @@ def has_expected_values(actual):
assert_that(result, has_expected_values)
- def test_combining_with_sliding_windows_and_fanout_raises_error(self):
+ def test_combining_with_sliding_windows_and_fanout(self):
+ # SlidingWindows + fanout now works (fixed in 2.73.0).
+ # Previously this raised ValueError due to WindowInto re-evaluating
Review Comment:
line 589-582 - let's move this to PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
