aaltay commented on a change in pull request #9907:
URL: https://github.com/apache/beam/pull/9907#discussion_r492447574
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -476,6 +499,26 @@ def _add_argparse_args(cls, parser):
'time. NOTE: only supported with portable runners '
'(including the DirectRunner)')
+ def validate(self, unused_validator):
+ errors = []
+ if beam.version.__version__ >= '3':
Review comment:
I think when/if we reach to Beam version 3, we can remove this warning,
and all and etc and and enable by default without an option to disable. So
maybe we do not need this?
##########
File path: CHANGES.md
##########
@@ -73,6 +73,10 @@
* In Interactive Beam, ib.show() and ib.collect() now have "n" and "duration"
as parameters. These mean read only up to "n" elements and up to "duration"
seconds of data read from the recording
([BEAM-10603](https://issues.apache.org/jira/browse/BEAM-10603)).
* Initial preview of
[Dataframes](https://s.apache.org/simpler-python-pipelines-2020#slide=id.g905ac9257b_1_21)
support.
See also example at apache_beam/examples/wordcount_dataframe.py
+* Fixed support for type hints on `@ptransform_fn` decorators in the Python
SDK.
Review comment:
Maybe warn that the default might change in a 2.x version later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
