andresti opened a new pull request, #37932:
URL: https://github.com/apache/beam/pull/37932
### Summary
Fixes https://github.com/apache/beam/issues/37930
ProcessManager.stopProcess() calls destroy()/destroyForcibly() but never
Process.waitFor(), so terminated child processes remain as zombies in the
kernel process table.
On long-running Flink TaskManagers with --environment_type=PROCESS,
expansion service processes accumulate as zombies over time (176+ observed on
production hosts). Container-level init systems (dumb-init, tini) cannot help
because
the zombies are children of the still-running TaskManager — only the
parent can reap them.
### Changes
Adds process.waitFor() calls in:
- stopProcess() — after the destroy/destroyForcibly sequence
- killAllProcesses() — after destroyForcibly in the shutdown hook path
### Testing
Existing ProcessManagerTest suite passes. The zombie issue is only
observable at the OS level over time and cannot be meaningfully unit-tested —
it was confirmed by monitoring production Flink pods.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
