ahmedabu98 commented on code in PR #37830:
URL: https://github.com/apache/beam/pull/37830#discussion_r2990719051
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema.proto:
##########
@@ -174,6 +174,13 @@ message LogicalTypes {
// A variable-length string with its maximum length as the argument.
VAR_CHAR = 7 [(org.apache.beam.model.pipeline.v1.beam_urn) =
"beam:logical_type:var_char:v1"];
+
+ // A URN for Date type
+ // - Representation type: INT64
+ // - A date without a timezone, represented by the number of days
+ // since the epoch.
+ DATE = 8 [(org.apache.beam.model.pipeline.v1.beam_urn) =
Review Comment:
Time is not as straightforward due to parameterized precision. I'd rather do
it in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
