Abacn commented on code in PR #37974:
URL: https://github.com/apache/beam/pull/37974#discussion_r3001342141
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -595,8 +595,9 @@ def _stage_resources(self, pipeline, options):
else:
remote_name = os.path.basename(type_payload.path)
is_staged_role = False
-
- if self._enable_caching and not type_payload.sha256:
+ # compute sha256 even if caching is disabled.
+ # This is used to check the payload integrity along with caching.
+ if not type_payload.sha256:
Review Comment:
For same feature flag purpose, shall we also skip computing sha256 (to
presere original behavior) if disable_integrity_check experiment is set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
