damccorm commented on code in PR #37787:
URL: https://github.com/apache/beam/pull/37787#discussion_r3002840953
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageSourceBase.java:
##########
@@ -156,13 +156,27 @@ public List<BigQueryStorageStreamSource<T>> split(
streamCount = Math.max(streamCount, MIN_SPLIT_COUNT);
}
+ String project =
+ bqOptions.getBigQueryProject() == null
+ ? bqOptions.getProject()
+ : bqOptions.getBigQueryProject();
+ if (project == null) {
+ if (targetTable != null
+ && targetTable.getTableReference() != null
+ && targetTable.getTableReference().getProjectId() != null) {
+ project = targetTable.getTableReference().getProjectId();
+ } else {
+ @Nullable String tableReferenceId = getTargetTableId(bqOptions);
+ if (tableReferenceId != null) {
+ TableReference tableReference =
BigQueryHelpers.parseTableUrn(tableReferenceId);
+ project = tableReference.getProjectId();
+ }
+ }
+ }
Review Comment:
Nice - this seems generally useful. Does this mean we can get rid of
https://github.com/apache/beam/blob/d48108d6f8319f1bea19ca527026a25047fcbee0/sdks/python/build.gradle#L178
as well? If so, would you mind adding a follow on pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
