tvalentyn opened a new pull request, #38070: URL: https://github.com/apache/beam/pull/38070
Python beam 2.72.0 containers fail pip check. ``` docker run --rm -it --entrypoint=/bin/bash apache/beam_python3.11_sdk:2.72.0 root@dba2986b7302:/# pip check apache-beam 2.72.0 requires pillow, which is not installed. ``` The rootcause: - pillow was was added in https://github.com/apache/beam/pull/37735/changes due to merge conflict (adding it was the right thing to do, but we overlooked that deps were not regenerated). - The test suite that verified dependencies failed in https://github.com/apache/beam/actions/runs/22566799492/job/65364608931 but went unnoticed because at that time we were merging on red and tests were a mess. - The test suite that can catch this is not part of the release suite - as far as I can tell, it didn't run on https://github.com/apache/beam/pull/37839, hence this PR. I have the following asks that should help reduce preventable issues in the release : - We should take a look whether any other tests suites need to be amended to also run during release branch validation. - We need to change the release procedure to rerun tests on the release validation PR after making cherry-pick changes. If we only run the tests once, we might miss errors like this. - We should investigate errors on the test suite validation PR before proceeding with the release: https://github.com/apache/beam/pull/37839#issuecomment-4145239124 Thanks! cc: @Amar3tto @damccorm @Abacn @claudevdm ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
