arunpandianp commented on code in PR #38073:
URL: https://github.com/apache/beam/pull/38073#discussion_r3041932965
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingCommitFinalizer.java:
##########
@@ -138,7 +138,7 @@ public void cacheCommitFinalizers(Map<Long, Pair<Instant,
Runnable>> callbacks)
// Start the cleanup thread lazily for pipelines that don't use
finalization callbacks
// and some tests.
cleanUpThreadStarted = true;
- finalizationExecutor.execute(this::cleanupThreadBody, 0);
+ finalizationExecutor.forceExecute(this::cleanupThreadBody, 0);
Review Comment:
can we move the forceExecute to after releasing the lock `lock.unlock`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
