aIbrahiim commented on code in PR #38162:
URL: https://github.com/apache/beam/pull/38162#discussion_r3075104438
##########
sdks/java/container/license_scripts/license_script.sh:
##########
@@ -39,8 +46,19 @@ echo "Copying already-fetched licenses from
${EXISTING_LICENSE_DIR} to ${DOWNLOA
if [ -d "$DOWNLOAD_DIR" ]; then rm -rf "$DOWNLOAD_DIR" ; fi
mkdir -p "$DOWNLOAD_DIR"
cp -r "${EXISTING_LICENSE_DIR}"/*.jar "${DOWNLOAD_DIR}"
-python -m venv --clear ${ENV_DIR} --without-pip --system-site-packages
+${PYTHON} -m venv --clear ${ENV_DIR} --without-pip --system-site-packages
. ${ENV_DIR}/bin/activate
+if ! python -m pip --version >/dev/null 2>&1; then
Review Comment:
no as after activate, python is the venv interpreter on PATH. ${PYTHON} is
still thr gradle chosen binary (sometimes an absolute path), so ${PYTHON} -m
pip could bypass the venv so we need python -m pip (or "${ENV_DIR}/bin/python"
-m pip) so installs run inside this env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
