dejii commented on PR #38149: URL: https://github.com/apache/beam/pull/38149#issuecomment-4239438420
> Thanks @dejii, overall this looks good. I'm wondering though, if our assumption that closing the Catalog will indeed close all underlying FileIOs. Did you check if this is true for different catalog implementations? @ahmedabu98 Yes, confirmed - verified against source and included links in the PR description. REST, Glue, JDBC, and Nessie catalogs all properly close their `FileIO` via `CloseableGroup` in `close()`. Hadoop and Hive catalogs do not close their FileIO, but this is likely intentional - they default to [HadoopFileIO](https://github.com/apache/iceberg/blob/2114bf631e49af532d66e2ce148ee49dd1dd1f1f/core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java) which has no `close()` implementation since Hadoop's FileSystem manages its own lifecycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
