damccorm commented on code in PR #37377:
URL: https://github.com/apache/beam/pull/37377#discussion_r3079462008
##########
sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go:
##########
@@ -57,8 +57,10 @@ type JobOptions struct {
NoUsePublicIPs bool
NumWorkers int64
DiskSizeGb int64
- DiskType string
- MachineType string
+ DiskType string
+ DiskProvisionedIops int64
+ DiskProvisionedThroughputMibps int64
+ MachineType string
Review Comment:
These don't look correctly formatted - could you please run `go fmt` to fix?
##########
sdks/go/pkg/beam/runners/dataflow/dataflow.go:
##########
@@ -61,9 +61,11 @@ var (
numWorkers = flag.Int64("num_workers", 0, "Number of
workers (optional).")
workerHarnessThreads = flag.Int64("number_of_worker_harness_threads",
0, "The number of threads per each worker harness process (optional).")
maxNumWorkers = flag.Int64("max_num_workers", 0, "Maximum
number of workers during scaling (optional).")
- diskSizeGb = flag.Int64("disk_size_gb", 0, "Size of root
disk for VMs, in GB (optional).")
- diskType = flag.String("disk_type", "", "Type of root
disk for VMs (optional).")
- autoscalingAlgorithm = flag.String("autoscaling_algorithm", "",
"Autoscaling mode to use (optional).")
+ diskSizeGb = flag.Int64("disk_size_gb", 0, "Size of
root disk for VMs, in GB (optional).")
+ diskType = flag.String("disk_type", "", "Type of
root disk for VMs (optional).")
+ diskProvisionedIops = flag.Int64("disk_provisioned_iops", 0,
"Provisioned IOPS for the worker disk (optional).")
+ diskProvisionedThroughputMibps =
flag.Int64("disk_provisioned_throughput_mibps", 0, "Provisioned throughput in
MiB/s for the worker disk (optional).")
Review Comment:
I agree that I would've expected this to show up in
https://github.com/apache/beam/blob/3f5ce80418be222c4243e2003041048041ae54e0/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go#L188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
