TheNeuralBit commented on a change in pull request #12780:
URL: https://github.com/apache/beam/pull/12780#discussion_r493808821
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/DropFields.java
##########
@@ -85,9 +85,8 @@ private Inner(FieldAccessDescriptor fieldsToDrop) {
FieldAccessDescriptor complement(Schema inputSchema, FieldAccessDescriptor
input) {
// Create a FieldAccessDescriptor that select all fields _not_ selected
in the input
- // descriptor. Maintain
- // the original order of the schema.
- Set<String> fieldNamesToSelect = Sets.newHashSet();
+ // descriptor. Maintain the original order of the schema.
+ List<String> fieldNamesToSelect = newArrayList();
Review comment:
Is this fixing a bug where field order isn't maintained? If so we should
break it out into a separate PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
