stankiewicz opened a new pull request, #38197:
URL: https://github.com/apache/beam/pull/38197
Enabled UndefinedEquals check
Registrars and Options comparing Iterables:
- DirectRegistrarTest.java: Wrapped test options in Lists.newArrayList.
- SparkStructuredStreamingRunnerRegistrarTest.java: Wrapped test options in
Lists.newArrayList.
- SparkRunnerRegistrarTest.java: Wrapped test options and runners in
Lists.newArrayList.
- DataflowPipelineRegistrarTest.java: Wrapped test options and runners in
Lists.newArrayList.
Tests comparing raw Collections or Iterables:
- JdbcSchemaIOProviderTest.java: Converted expected set to list using Guava
collections.
- LazyCachingIteratorToIterableTest.java: Declared proper concrete types on
LazyCachingIteratorToIterable.
- FutureUtilsTest.java: Bound raw results explicitly inside
Lists.newArrayList.
- ArtifactStagingServiceTest.java: Changed method signature bounds to List
to support clean list equality.
- SamzaTimerInternalsFactoryTest.java: Wrapped source collections in clean
ArrayList.
- ValueAndCoderLazySerializableTest.java: Wrapped accumulators in
Lists.newArrayList.
- StreamingDataflowWorkerTest.java: Applied list wrapping around generic
collection decoders on consecutive items.
- UngroupedShuffleReaderTest.java: Wrapped standard element windows arrays
inside Lists.newArrayList to match list.
- ShuffleSinkTest.java: Applied exact equality matching lists on windows
expectations.
Helper classes doing invalid raw checks:
- WindmillStateInternalsTest.java: Fixed an explicit equals method that used
Objects.equals on target raw Iterable objects, by applying a null safe usage of
Guava's Iterables.elementsEqual to enforce correct iteration based content
checking.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
