gemini-code-assist[bot] commented on code in PR #36603:
URL: https://github.com/apache/beam/pull/36603#discussion_r3086273256
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -1548,6 +1548,8 @@ def create_transform(
"""Creates a PTransform instance for the given transform type and
arguments.
"""
mappings = self._mappings[typ]
+ # NOTE: If the `key` is not found in the mappings (e.g. standard_io.py),
the
+ # `key` is passed down as is to the underlying transform.
Review Comment:
The comment refers to `standard_io.py`, but the mappings are defined in
`standard_io.yaml`. This appears to be a typo, likely influenced by the same
naming confusion in the PR description.
```suggestion
# NOTE: If the `key` is not found in the mappings (e.g.
standard_io.yaml), the
# `key` is passed down as is to the underlying transform.
```
##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -74,6 +74,7 @@
'error_handling': 'error_handling'
'file_descriptor_path': 'file_descriptor_path'
'message_name': 'message_name'
+ 'max_read_time_seconds': 'max_read_time_seconds'
Review Comment:
To improve consistency and documentation, consider explicitly mapping other
common Kafka parameters like `topic`, `bootstrap_servers`, `format`, and
`consumer_config`. This ensures they are visible in any generated documentation
for the YAML provider, following the pattern of making parameters explicit as
mentioned in the PR description.
```yaml
'topic': 'topic'
'bootstrap_servers': 'bootstrap_servers'
'format': 'format'
'consumer_config': 'consumer_config'
'max_read_time_seconds': 'max_read_time_seconds'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
