ahmedabu98 commented on code in PR #38194:
URL: https://github.com/apache/beam/pull/38194#discussion_r3088227419
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ByteBuddyUtils.java:
##########
@@ -286,6 +352,8 @@ public T convert(TypeDescriptor<?> typeDescriptor) {
return convertDateTime(typeDescriptor);
} else if
(typeDescriptor.isSubtypeOf(TypeDescriptor.of(ReadablePartial.class))) {
return convertDateTime(typeDescriptor);
+ } else if (javaTimeLogicalTypeFor(typeDescriptor.getRawType()) != null) {
+ return convertJavaTimeLogicalType(typeDescriptor);
Review Comment:
Wondering if we can expand the naming of this logic to include other
LogicalTypes in the future? Instead of restricting it to just Time types. We
already include UUID, might as well open it up to other LogicalTypes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
