dejii commented on PR #38149: URL: https://github.com/apache/beam/pull/38149#issuecomment-4256393512
@ahmedabu98 @stankiewicz -- reworked the PR based on the discussion so far. Key notes: What | Previous (before PR) | This PR -- | -- | -- Catalog instance | One per DoFn thread (depending on the runner) | One per VM Table cache | Static, shared across VM | Static, shared across VM (unchanged) FileIO close | Per-bundle in `RecordWriterManager.close()`, also in `AppendFilesToTables` and `ScanTaskReader` | Never — JVM/container shutdown handles cleanup Catalog quota impact (init calls) | N per VM | 1 per VM `loadTable()` calls at startup | One per table per VM (static cache) | One per table per VM (unchanged) Resource cleanup | Premature — killed shared connection pool when using dynamic destinations | JVM lifecycle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
