tysonjh commented on pull request #12915: URL: https://github.com/apache/beam/pull/12915#issuecomment-697981031
> Out of curiosity, why are you adding this here instead of the schema join library (which SQL uses)? I wasn't aware of the other join library. I saw the join extension library implementations, plus the previously closed PR in BEAM-7386, and thought that this new one should be placed near and made the assumption that SQL would reuse the implementation. Looking at it now though it seems like the SQL joins don't use the join extension library. Should I keep this one around or refactor into the SQL schema join library? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
