tkaymak commented on PR #38233:
URL: https://github.com/apache/beam/pull/38233#issuecomment-4269856975
Good catch @gemini-code-assist — applied. The `if (use_override)` branch now
reads:
```groovy
sourceSets {
main {
java { srcDirs = [copySourceOverrides] }
resources { srcDirs = [copyResourcesOverrides] }
}
test {
java { srcDirs = [copyTestSourceOverrides] }
resources { srcDirs = [copyTestResourcesOverrides] }
}
}
```
Dropped the manual `compileJava.dependsOn …` / `processResources.dependsOn
…` block and the `findByName('sourcesJar')` null-guards entirely — Gradle
auto-wires dependencies for every consumer of the source set (including
`javadoc`, which the manual list was indeed missing).
Note: `runners/flink/flink_runner.gradle` still uses the old
manual-dependsOn pattern. Worth a follow-up to align it; out of scope for this
PR.
Force-pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
