Abacn commented on code in PR #38108:
URL: https://github.com/apache/beam/pull/38108#discussion_r3113264974
##########
sdks/python/apache_beam/typehints/schema_registry.py:
##########
@@ -43,6 +43,15 @@ def add(self, typing, schema):
if schema.id:
self.by_id[schema.id] = (typing, schema)
+ def load_registered_typings(self, by_id):
+ for id, typing in by_id.items():
+ if id not in self.by_id:
+ self.by_id[id] = (typing, None)
Review Comment:
No actual conflict happening. schema object has an "id" field (schema.id).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
