stankiewicz opened a new pull request, #38256:
URL: https://github.com/apache/beam/pull/38256
## Description
This PR resolves violations for several ErrorProne checks that were
previously disabled in `BeamModulePlugin.groovy`.
## Changes by ErrorProne Check
### AutoValueSubclassLeaked
- **`sdks/java/io/google-cloud-platform`**:
- `BigQueryIO.java`: Added static `builder()` methods to `TypedRead` and
`Write` classes to avoid direct referencing of generated AutoValue builders.
- `BigQueryIOTranslation.java`: Updated to use new static builder
methods.
- `BigQueryCoderProviderRegistrar.java`: Replaced direct reference to
`AutoValue_RowMutation.class` with `RowMutation.class`.
- `WritePartition.java`: Added public static factory method `of(...)` to
`Result` class.
- `WriteTables.java`: Added public static factory method `of(...)` to
`Result` class.
- `BigQueryIOWriteTest.java`: Updated to use new factory methods.
- **`runners/java-fn-execution`**:
- `DefaultJobBundleFactory.java`: Added `builder()` method to
`ServerInfo` to avoid direct reference to
`AutoValue_DefaultJobBundleFactory_ServerInfo.Builder`.
- `DefaultJobBundleFactoryTest.java`: Updated to use the new builder.
- **`sdks/java/io/mongodb`**:
- `MongoDbIO.java`: Replaced `getClass() == AutoValue_FindQuery.class`
with `instanceof FindQuery` to avoid direct references to generated classes.
- **`sdks/java/core`**:
- `GenerateSequenceTest.java`: Replaced direct instantiation of
`AutoValue_GenerateSequence` with factory methods.
### EscapedEntity
- **`sdks/java/io/hadoop-format`**:
- `HadoopFormatIO.java`: Fixed HTML entities like `<` and `"`
inside Javadoc `{@code ...}` blocks.
- **`sdks/java/core`**:
- `ApproximateQuantiles.java`: Fixed HTML entities like `<` inside
Javadoc `{@code ...}` blocks.
### JUnitIncompatibleType
- **`sdks/java/core`**:
- `LogicalTypesTest.java`: Fixed incompatible types in `assertEquals` by
using the correct expected class type.
### EqualsUnsafeCast
- **`sdks/java/core`**:
- `TestPOJOs.java`: Fixed wrong class in `instanceof` check in `equals`
method (checked `PojoWithNestedArray` but cast to `PojoWithIterable`).
### Build Configuration
- **`buildSrc`**:
- `BeamModulePlugin.groovy`: Enabled `AutoValueSubclassLeaked`,
`EqualsUnsafeCast`, `EscapedEntity`, `NonCanonicalType`, `UnescapedEntity`, and
`JUnitIncompatibleType` by removing them from `disabledChecks`.
## Verification
- Verified that compilation passes for the affected modules.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
