shnapz commented on code in PR #36781:
URL: https://github.com/apache/beam/pull/36781#discussion_r3131885919
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/BoundedTrieMetricsLineage.java:
##########
@@ -29,7 +30,8 @@ class BoundedTrieMetricsLineage implements LineageBase {
private final BoundedTrie metric;
- BoundedTrieMetricsLineage(Lineage.LineageDirection direction) {
+ @SuppressWarnings("unused")
+ public BoundedTrieMetricsLineage(PipelineOptions options,
Lineage.LineageDirection direction) {
Review Comment:
oh sorry, I misread your earlier nit as a rename suggestion
btw: Java unit tests passed green and Error-Prone UnusedVariable would fail
but it's not flagging the param here (likely because public constructors get a
pass).
Happy to put the annotation back if you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
